Closed hayesall closed 2 years ago
For the modified files (plots and csv's), the contents are the same. The metadata (time created) has been changed as the previous ones are overwritten. I will add these output files to .gitignore
.
For the data in the CSV files, the results (or the content within each file) are the same. It's just the formatting being different. Internally I'm using pandas' to_csv
for exporting data to csv file, and there is a minor update after the tutorial has been written.
Is there a backwards-compatibility reason for keeping old versions checked into git?
Or maybe they're used in a sphinx build?
(My bad if I'm missing something, this might be a non-issue!)
Actually no. The output files generated from the tutorials are there just for the demonstration of the export
functionality for the users. I just re-ran the 2b_data_preprocessing_exporting.ipynb to generate new output files so that the formatting is consistent. I think it's useful to keep the experiment_history folder there for reference (i.e., showing the users what is expected to happen). Does it make sense?
Okay, this makes sense! My bad, I somehow spaced that this came from a notebook in the first place.
After working through the Jupyter notebooks, my local git directory listed a large number of files as having been modified:
It looks like they are not being reproduced exactly.
Recommendation: Clarify whether these should be reproduced exactly, update copies on remote branch, or add some of these files to a
.gitignore
Reproducing
(Run through the notebooks)
The previous version showed:
... and after re-running, they show: