xiota / geany-preview

Turns Geany into a markdown editor by providing a preview pane in the sidebar to show the formatting of several light-weight languages as they are edited. Supported document types include AsciiDoc, DocBook, Fountain, HTML, LaTeX, Markdown, MediaWiki, reStructuredText, Textile, and Txt2Tags.
GNU General Public License v3.0
15 stars 0 forks source link

Dark mode for plain text and "Unable to process type" message. #2

Closed xiota closed 3 years ago

xiota commented 3 years ago

I would like to change in the Preview-tab the white background of txt-documents.

In those documents there is the text "Unable to process type" with white background. Could it be that a change of the background-color in Preview is not possible for those documents?

ralf3u commented 2 years ago

I did an update. I deleted the config-file of preview and I deleted the config-file of xitweaks, and I deleted all css-files of preview, so I don't need to reload them. And I deleted geany.css. Then I restarted Geany.

issue a was fixed

issue b was not fixed. If I press the shortcut toggle editor/sidebar, then the tab-title "Preview" is in focus. The goal should be: Not the tab-title "Preview" should be in focus, but the content of the Preview-tab. Two tests if the goal was achieved with a very long html-document, and with at least two tabs in the sidebar: test 1: Open Geany, press the shortcut toggle editor/sidebar, then press the arrow-left-key once: the Preview-tab should still be in focus. test 2: Open Geany, press the shortcut toggle editor/sidebar, then press the arrow-down-key once: the html-document should move downwards.

issue c I added in geany.css the rules, mentioned in the previous comment. This is the result:

xiota commented 2 years ago

In geany.css, these rules control the tab style.

#geany-xitweaks-sidebar-tab-focus {
}
#geany-xitweaks-sidebar-tab-unfocus {
}

These rules control the page:

#geany-xitweaks-sidebar-page-focus {
}
#geany-xitweaks-sidebar-page-unfocus {
}
#geany-preview-sidebar-page {
}

This rule controls the white outline on the tab:

notebook header tabs > * {
    outline-width: 0;
}

With extra_css=disable, the default webview color, before the document loads, is white. Set it to something to change the default color. The geany.css style only controls the window style, which is different from the webview style.

ralf3u commented 2 years ago

The geany.css style only controls the window style, which is different from the webview style.

OK, background is now fixed. There is no white flash any more.

And what about the issue b? And what about the green color that is missing?

Thank you for an answer in advance.

xiota commented 2 years ago

The goal should be: Not the tab-title "Preview" should be in focus, but the content of the Preview-tab.

You need to edit geany.css to make it do what you want. I don't know what rules you are using.

ralf3u commented 2 years ago

You need to edit geany.css to make it do what you want. I don't know what rules you are using.

issue b: I'm sure that a solution of issue b has nothing to do with geany.css.

issue c:

xiota commented 2 years ago

I don't know what the issues are now. Please re-describe them. Don't link back or copy from a previous comment because I do not understand your previous descriptions.

For now, make geany.css have the contents from earlier, even if it doesn't do exactly what you want (tab text color and bold) so I can figure out if there is another issue.

ralf3u commented 2 years ago

For now, make geany.css have the contents from earlier, even if it doesn't do exactly what you want (tab text color and bold) so I can figure out if there is another issue.

OK.


issue shortcut (I'm sure that this issue has nothing to do with geany.css) If I press the shortcut toggle editor/sidebar, then the tab-title "Preview" is in focus. The goal should be: Not the tab-title "Preview" should be in focus, but the content of the Preview-tab. Two tests if the goal was achieved with a very long html-document, and with at least two tabs in the sidebar: TEST 1: Open Geany, press the shortcut toggle editor/sidebar, then press the arrow-left-key once: the content of the Preview-tab should still be in focus. TEST 2: Open Geany, press the shortcut toggle editor/sidebar, then press the arrow-down-key once: the html-document should move downwards.


issue green color

xiota commented 2 years ago

Thanks for explaining. If it seems that I don't understand again, it might help to try another explanation.

If I press the shortcut toggle editor/sidebar, then the tab-title "Preview" is in focus. The goal should be: Not the tab-title "Preview" should be in focus, but the content of the Preview-tab.

When you say "focus" are you referring to the color or the part of the widget that takes keyboard input?

issue green color "Preview" is not green when I click on it or when I press the shortcut toggle editor/sidebar

There are various issues with this feature that never really worked. Is this one of those? In the future when referencing these types of problems, please note that they are "old issue, still not fixed". That way I don't get confused and think you're trying to describe something new.

something is strange: in an html-document, an a-tag without style: when I go in the Preview-tab with the mouse over the link, the link becomes green, although it should not become green (it will not become green in the browsers Firefox and Web)

Are you using the extra_css option? The extra-media.css file does style links.

ralf3u commented 2 years ago

issue green color "Preview" is not green when I click on it or when I press the shortcut toggle editor/sidebar

feedback Yesterday morning I did an update: The green color is back. This morning I did an update: The green color is back.

xiota commented 2 years ago

This morning I did an update: The green color is back.

I don't know if the problem is whether you want the green color or not.

I don't know what is becoming green. If it is the tab, label, that is controlled by geany.css. If it is a link within the webpage, it is controlled by the css files inside .config/geany/plugins/preview/.

ralf3u commented 2 years ago

I don't know if the problem is whether you want the green color or not.

Now where the green color is back, it is not a problem any more. Some days ago the green color was not there any more. With green color I mean the tab-title in the sidebar.

xiota commented 2 years ago

it is not a problem any more

Thanks for letting me know. I don't know if I'll be able to get this feature working properly because GTK doesn't seem to have the signals needed to reliably detect when the widget has focus. I'll keep it in mind in case I come across a solution.

ralf3u commented 2 years ago

To the green color: I would like to make a better differentiation, so there is no misunderstanding:

xiota commented 2 years ago

@ralf3u Thank you for the update/clarification.