search

xiph / libopusenc

Library for encoding .opus audio files and live streams.
BSD 3-Clause "New" or "Revised" License
108 stars 39 forks source link

Fix pull_api mode #2

Closed miv-ableton closed 7 years ago

miv-ableton commented 7 years ago

Hi! I'm new to this codebase, so hopefully these changes make sense. I was trying to use the pull_api mode, but found that it didn't work. With the changes here, I am able to make working Opus files using the pull mode.

See the commit comment for more details, and let me know if you have any further questions. Thanks!

jmvalin commented 7 years ago

Looks reasonable. I'll have a closer look and likely merge it (ping me if I don't). Just curious, are you using that API?

miv-ableton commented 7 years ago

At this point I'm just experimenting. I needed to use a specific filesystem layer, and the pull mode was the first thing I grabbed at to help me. I could probably switch over to the callback mode quite easily.

miv-ableton commented 7 years ago

Ping?

jmvalin commented 7 years ago

Thanks for the reminder. It's merged in master.