search

xiph / opus-tools

A set of tools to encode, inspect, and decode audio in the Opus format.
https://opus-codec.org/
Other
214 stars 78 forks source link

When opus payload type is other than 120; opusrtp --extract fails to generate rtpdump.opus #31

Closed adil-mafzool closed 6 years ago

adil-mafzool commented 6 years ago

When opus payload type is other than 120; opusrtp --extract fails to generate rtpdump.opus

mark4o commented 6 years ago

Thanks for the patch!

There was another pull request that adds an opusrtp -t option to specify the payload type, and yours conflicts with that one. Also if there were multiple dynamic payload types present, writing them all to the same stream would not work. However you have a good point that the user shouldn't have to specify the payload type if there is only one. So I updated your patch to work with the other pull request; if an output file is specified but no -t option, then instead of defaulting to payload type 120 it will record the first dynamic payload type seen with a packet that could be a valid Opus packet. Once it finds a payload type it will just record that one so that the stream won't be garbled with packets from multiple payload types.