search

xiph / opus-tools

A set of tools to encode, inspect, and decode audio in the Opus format.
https://opus-codec.org/
Other
212 stars 78 forks source link

configure: make libflac really optional #52

Closed eblanca closed 4 years ago

eblanca commented 4 years ago

opus-tools can actually be built without flac support, but the default behavior for configure is to raise an error when flac is not detected, why? This should be optional, as in vorbis-tools. Well, when the user asks for flac AND the detection fails, then an error is due but why halt the build when flac is optional?

mark4o commented 4 years ago

By default opus-tools is built with FLAC support, but this can be disabled by configuring with "./configure --without-flac". If the --without-flac option is used, it will not look for FLAC.

Some packages check for optional dependencies and turn them off automatically if not found, but this can lead unintentionally missing features. This way, if you don't want the feature you can intentionally turn it off, but it won't be missing by accident, because you built the libraries in the wrong order or had them in the wrong directory or some other reason.

eblanca commented 4 years ago

ok