xiph / opus-tools

A set of tools to encode, inspect, and decode audio in the Opus format.
https://opus-codec.org/
Other
212 stars 78 forks source link

Opusenc from git fails to encode very short flac files on windows #78

Open MarcroSoft opened 1 year ago

MarcroSoft commented 1 year ago

Hi. I made an issue about this in the opus repo but it's related to opus-tools instead. When I try to encode a short flac file with opusenc it says: ERROR: Could not open FLAC stream. Error: unsupported input file: synth1.flac I compiled opus-tools 0.2 with dynamic libflac and that worked, but not the version from git, neither dynamic or static. (Haven't tried 0.2 static yet). I can try to bisect it, but as I get no audio by inverting a file with the git version and 0.2 it's really low priority. But if you know of a git change after 0.2 that has to do with flac input that might be it. Thanks, Marc

MarcroSoft commented 1 year ago

I'm finished bisecting, and here it is: 5d0ac2030244b33bf12512267fe62ffe831bf105 is the first bad commit
commit 5d0ac2030244b33bf12512267fe62ffe831bf105
Author: Thomas Daede daede003@umn.edu
Date: Fri Jan 21 07:03:46 2022 -0800

Allow FLAC files with ID3 tags to pass the ID check.                                                                

Signed-off-by: Mark Harris <mark.hsj@gmail.com>                                                                     

src/audio-in.c | 10 ++++------
src/flac.c | 19 ++++++++++++++++---
2 files changed, 20 insertions(+), 9 deletions(-)

Which makes sence because the commit has to do with flac files. You can take a look at it if you want.