xiph / rav1e

The fastest and safest AV1 encoder.
BSD 2-Clause "Simplified" License
3.73k stars 253 forks source link

Fix NASM warning about %undef statement #3329

Closed FreezyLemon closed 10 months ago

FreezyLemon commented 11 months ago

My local version of NASM (2.16.01) produces some warnings when compiling:

warning: trailing garbage after macro name ignored [-w+pp-trailing]
/.../sse.asm:444: ... from macro `WEIGHTED_SSE' defined here

Looks like the %undef sum, kernel_width, res only undefines sum and ignores everything after that. res doesn't seem to exist (anymore), so I removed it from the %undefs.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (585b244) 88.53% compared to head (c3a3db1) 88.53%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3329 +/- ## ======================================= Coverage 88.53% 88.53% ======================================= Files 89 89 Lines 28330 28330 ======================================= Hits 25082 25082 Misses 3248 3248 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.