search

xiph / rav1e

The fastest and safest AV1 encoder.
BSD 2-Clause "Simplified" License
3.73k stars 253 forks source link

Add whitespace to compiler flags in long version string #3346

Closed FreezyLemon closed 10 months ago

FreezyLemon commented 10 months ago

From the reference regarding environment variables set by Cargo:

CARGO_ENCODED_RUSTFLAGS — extra flags that Cargo invokes rustc with, separated by a 0x1f character (ASCII Unit Separator).

Before:

Compiler Flags: -Ctarget-cpu=native-Clink-arg=-fuse-ld=mold

After:

Compiler Flags: -C target-cpu=native -C link-arg=-fuse-ld=mold
codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f6f4969) 88.53% compared to head (94e0623) 88.54%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3346 +/- ## ======================================= Coverage 88.53% 88.54% ======================================= Files 89 89 Lines 28330 28334 +4 ======================================= + Hits 25082 25087 +5 + Misses 3248 3247 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shssoichiro commented 10 months ago

Interesting. tbh I didn't realize the previous version didn't even have a space between the different flags.