search

xiph / rnnoise

Recurrent neural network for audio noise reduction
BSD 3-Clause "New" or "Revised" License
3.97k stars 890 forks source link

Add rnnoise_get_frame_size() #133

Closed lu-zero closed 3 years ago

lu-zero commented 4 years ago

It provides a mean to know how many samples are processed at time.

petterreinholdtsen commented 3 years ago

Can you tell more about why you need this method? Perhaps more information can convince the lead developer to include it?

tmatth commented 3 years ago

Can you tell more about why you need this method? Perhaps more information can convince the lead developer to include it?

I'm guessing it's to avoid clients have to know internals about the library, see e.g.,: http://git.videolan.org/?p=vlc.git;a=blob;f=modules/audio_filter/rnnoise.c;h=34229f0012487ffe00f932238b8d990e861e3b22;hb=HEAD#l77

lu-zero commented 3 years ago

Exactly what @tmatth said :)

lu-zero commented 3 years ago

Documentation errors addressed.

petterreinholdtsen commented 3 years ago

Right, so at least VLC need the value, and have to hardcode it because it is not available from the library. Sound convincing to me.