search

xiph / rnnoise

Recurrent neural network for audio noise reduction
BSD 3-Clause "New" or "Revised" License
3.89k stars 882 forks source link

CMake support, modernized rnnoise example with libsoundfile and CI setup based on Github Actions #227

Open ValentiWorkLearning opened 2 months ago

ValentiWorkLearning commented 2 months ago

Thanks for this great work over this library. I've decided to add CMake support for rnnoise and introduce CI/CD build setup for the project, since it seems to be convenient way of PRs checking for Linux/Windows builds. Also, this PR introduces slightly modernised version of rnnoise example using libsoundfile with the capability of reading WAVE files instead

petterreinholdtsen commented 2 months ago

[Valentyn Korniienko]

I've decided to add CMake support for rnnoise and introduce CI/CD build setup for the project, since it seems to be convenient way of PRs checking for Linux/Windows builds.

Which build systems did you consider and why did you pick cmake?

I have nothing against the current build system nor cmake, just curiuos why you believe a change is required and why you ended up with your selection.

-- Happy hacking Petter Reinholdtsen

ValentiWorkLearning commented 2 months ago

@petterreinholdtsen the reason is simple-just because CMake is cross-platform and well supported by IDEs like VSCode/Visual Studio/XCode. I was thinking about bazel, but it doesn't have native support by IDEs.