search

xiph / speexdsp

Speex audio processing library - THIS IS A MIRROR, DEVELOPMENT HAPPENS AT https://gitlab.xiph.org/xiph/speexdsp
https://speex.org
Other
490 stars 191 forks source link

Make JitterBufferPacket user_data a pointer sized field #24

Open eliotmiranda opened 5 years ago

eliotmiranda commented 5 years ago

Make JitterBufferPacket.user_data a pointer sized field so that in 64 bits it can contain a pointer if required.

tmatth commented 5 years ago

@eliotmiranda good catch, I'm wondering if it would make more sense for this to simply be a void *, as I think uintptr_t requires C99 or higher.

eliotmiranda commented 5 years ago

Happy either way. But uintptr_t is likely to have less impact on existing clients, so maybe feature-detect C99 and fall back on void * in 64-bits. Messy :-). One could of course define uintptr_t in speex_jitter.h if in 64-bits and not C99.