Closed LRFLEW closed 3 years ago
Thanks, applied here: https://gitlab.xiph.org/xiph/speexdsp/-/commit/095fd36e189554bbcbfd9884630a53d7792409dc
Cool. I hadn't realized there was now a xiph gitlab. I'm messing with this project (and specifically its autoconf setup), so I might find more things to make pull/merge requests for. Is the preferred location for that the gitlab repo?
Cool. I hadn't realized there was now a xiph gitlab. I'm messing with this project (and specifically its autoconf setup), so I might find more things to make pull/merge requests for. Is the preferred location for that the gitlab repo?
Yeah exactly.
I found what appears to be a few typos in
libspeexdsp/arch.h
in the option combination tests.One check looks for
FIXED_POINT_DEBUG
, but this is the only time a macro by this name is ever used in the project (or in libspeex). This seems like it was meant to beFIXED_DEBUG
based on the error message, so I changed it.The check for the ARM optimization macros has
(defined (ARM4_ASM)||defined (ARM4_ASM))
, which is redundant. Based on the context, I assume this was meant to be(defined (ARM4_ASM)||defined (ARM5E_ASM))
. I ended up replacing the entire check with a simpler version that utilizes the fact that the sum of boolean comparisons is the count of true values.There were a few cases of inconsistent whitespace usage in this file. In the other files in the project,
defined()
did not have a space before the parenthesis, but spaces were inconsistently added in this file. I went ahead and removed all these spaces to make the file consistent with the rest of the project.There was something else I was unable to figure out what was going on with. There are a few instances of the macos
CONFIG_TI_C54X
,CONFIG_TI_C55X
, andCONFIG_TI_C6X
in the project, but not in the configuration. Theconfigure.ac
file does have an option that defines the macroTI_C55X
, but this macro isn't used anywhere in the project (or in libspeex). I'm not sure what's going on here, so I've left it alone, but this probably needs to be looked into.