xiph / speexdsp

Speex audio processing library - THIS IS A MIRROR, DEVELOPMENT HAPPENS AT https://gitlab.xiph.org/xiph/speexdsp
https://speex.org
Other
490 stars 191 forks source link

Fix incorrect macro names in arch.h #33

Closed LRFLEW closed 3 years ago

LRFLEW commented 3 years ago

I found what appears to be a few typos in libspeexdsp/arch.h in the option combination tests.

There was something else I was unable to figure out what was going on with. There are a few instances of the macos CONFIG_TI_C54X, CONFIG_TI_C55X, and CONFIG_TI_C6X in the project, but not in the configuration. The configure.ac file does have an option that defines the macro TI_C55X, but this macro isn't used anywhere in the project (or in libspeex). I'm not sure what's going on here, so I've left it alone, but this probably needs to be looked into.

tmatth commented 3 years ago

Thanks, applied here: https://gitlab.xiph.org/xiph/speexdsp/-/commit/095fd36e189554bbcbfd9884630a53d7792409dc

LRFLEW commented 3 years ago

Cool. I hadn't realized there was now a xiph gitlab. I'm messing with this project (and specifically its autoconf setup), so I might find more things to make pull/merge requests for. Is the preferred location for that the gitlab repo?

tmatth commented 3 years ago

Cool. I hadn't realized there was now a xiph gitlab. I'm messing with this project (and specifically its autoconf setup), so I might find more things to make pull/merge requests for. Is the preferred location for that the gitlab repo?

Yeah exactly.