search

xiph / speexdsp

Speex audio processing library - THIS IS A MIRROR, DEVELOPMENT HAPPENS AT https://gitlab.xiph.org/xiph/speexdsp
https://speex.org
Other
469 stars 190 forks source link

libspeexdsp.def: add .dll extension to def file #44

Closed neheb closed 2 years ago

neheb commented 2 years ago

MSVC doesn't completely respect this line but MinGW does. Specify the name properly.

tmatth commented 2 years ago

Applied here, thanks: https://gitlab.xiph.org/xiph/speexdsp/-/merge_requests/13

tmatth commented 2 years ago

@neheb would you mind doing the same fix for speex here: https://gitlab.xiph.org/xiph/speex

Specifically on https://gitlab.xiph.org/xiph/speex/-/blob/master/win32/libspeex.def

neheb commented 2 years ago

So actually I think this commit was partially wrong. I'll fix it differently.

edit: actually never mind. I'm so confused...

neheb commented 2 years ago

@tmatth there's no way to contribute using that gitlab instance. Forks are not allowed.

In any case, basic testing indicates this is good to do but it is not required. And actually a better solution is to use _declspec(dllexport).