xiph / theora

Reference implementation of the Theora video compression format.
https://theora.org/
Other
98 stars 66 forks source link

remove redundant assignments #13

Open mcmtroffaes opened 3 years ago

mcmtroffaes commented 3 years ago

Currently, the windows msvc debug build of theora will crash due to the compiler identifying the use of uninitialized memory. These crashes can be traced back to some redundant assignments in the source code. This patch removes those assignments, fixing the problem. The patch has been carried downstream in vcpkg for some time: https://github.com/microsoft/vcpkg/blob/1a07422d3dd3e58f1d2eb132d0e54fbf82f1ac48/ports/libtheora/0001-fix-uwp.patch

mcmtroffaes commented 3 years ago

https://gitlab.xiph.org/xiph/theora/-/issues/2317