search

xiph / vorbis-tools

Command-line tools for creating and playing Ogg Vorbis files.
GNU General Public License v2.0
73 stars 28 forks source link

Unresolved Symbol #31

Open ptrstack opened 2 years ago

ptrstack commented 2 years ago

Hello.

I am building with Visual Studio 2022.

I have a problem with an unresolved symbol, in vorbiscomment.

In the function _vorbis_comment_rm_tag (vcomment.c), on line 193, I have replaced strncasecmp with _strnicmp.

I have compiled and the exe has worked. but I don't know if _strnicmp is the correct solution?

rillian commented 2 years ago

The signature looks compatible, and intl/os2compat.h as #define strncasecmp strnicmp so that's probably fine. Not sure how it was working with earlier Visual Studio versions though; maybe there is/was some define to make that function available by default?

Chocobo1 commented 1 year ago

This would be resolved by PR #16.