Don't export vorbisenc functions from vorbis.dll with CMake

xiph / vorbis

Reference implementation of the Ogg Vorbis audio format.

BSD 3-Clause "New" or "Revised" License

450 stars 183 forks source link

Don't export vorbisenc functions from vorbis.dll with CMake #64

Open evpobr opened 4 years ago

rillian commented 4 years ago

Please also add some documentation about why the export list changed to the commit message, so anyone looking for the change has an easier time understanding the motivation.

evpobr commented 4 years ago

I don't like the duplication of the .def file. If our goal is to replace the visual studio project files with cmake, and you want to change the ABI, we should just change the ABI for all win32 builds.

I don't understand. You want from me also fixing Visual Studio solutions to use updated DEF file?

rillian commented 4 years ago

That's correct. If we're changing the vorbis.dll ABI I think we should change it for all the builds.