Link test with -lm to fix build problem with ld --no-add-needed

[petterreinholdtsen]

0001-Fix-build-failure-with-DSO-link-changes.patch from Debian, see http://bugs.debian.org/604797 .

[rillian]

This seems harmless enough, but can you please give steps to reproduce? -lm should have already been added to VORBIS_LIBS by configure.

E.g. on my system (Debian bullseye):

$ make -f test/Makefile V=1 test
[...]
libtool: link: gcc -O3 -Wall -Wextra -ffast-math -D_REENTRANT -fsigned-char -Wdeclaration-after-statement -DUSE_MEMORY_H -o .libs/test util.o write_read.o test.o  ../lib/.libs/libvorbisenc.so ../lib/.libs/libvorbis.so -logg -lm
``
Note the `-lm` at the end of the link line without this patch.

[rillian]

Thanks to pere's help, I tested removing this patch on a Debian bullseye (testing) system and didn't see any build errors. I suggest debian try removing it from their stack.

$ apt-get install devscripts
$ apt-get source libvorbis
$ cd libvorbis-1.3.6
$ quilt pop -a
<Edit debian/patches/series to remove this change>
$ quilt push -a
$ debuild

or

$ apt-get install git-buildpackage
$ git clone https://salsa.debian.org/multimedia-team/libvorbis
$ cd libvorbis
<edit debian/patches/series to remove this change>
$ git commit -a -m "Remove patch for testing"
$ gbp buildpackage

Both successfully run tests before failing for lack of a signing key. Old-style fakeroot debian/rules binary succeeds in making packages.

[petterreinholdtsen]

[Ralph Giles]

Thanks to pere's help, I tested removing this patch on a Debian bullseye (testing) system and didn't see any build errors. I suggest debian try removing it from their stack.

I tested to build using 'LDFLAGS=-Wl,--no-copy-dt-needed-entries debuild' (the --no-add-needed options was renamed), and I suspect you are right, this patch is no longer needed.

-- Happy hacking Petter Reinholdtsen

[rillian]

Ok, thanks for confirming!