lib/os.h, test/util.c: define _USE_MATH_DEFINES for windows builds

xiph / vorbis

Reference implementation of the Ogg Vorbis audio format.

BSD 3-Clause "New" or "Revised" License

450 stars 183 forks source link

Closed sezero closed 3 years ago

sezero commented 3 years ago

it is required to access the M_PI macro.

uthidata commented 3 years ago

I'm not a dev or maintainer so I'm just going to link the related issue here https://github.com/xiph/vorbis/issues/75

sezero commented 3 years ago

PING?

sezero commented 3 years ago

PING?

rillian commented 3 years ago

I submitted a merge request with your patch rewritten to use the _MSC_VER conditional. It seems to be green.

rillian commented 3 years ago

Fixed instead by copying the fallback define from os.h in 894d1b1f22f2fb8ab6d3aeba863e143416c71ce2. https://gitlab.xiph.org/xiph/vorbis/-/merge_requests/20