xiph / vorbis

Reference implementation of the Ogg Vorbis audio format.
BSD 3-Clause "New" or "Revised" License
467 stars 188 forks source link

Stack overflow when writing ogg with long frames #99

Open littlecattle opened 1 year ago

littlecattle commented 1 year ago

Should be allocated on heap to avoid stack overflow caused by long frames? https://github.com/xiph/vorbis/blob/84c023699cdf023a32fa4ded32019f194afcdad0/lib/block.c#L420

ssaue commented 12 months ago

This bug is particularly critical on Windows which appears to have a smaller stack by default

AlexTMjugador commented 10 months ago

I have fixed this on #104.