xiphonics / picoTracker

BSD 3-Clause "New" or "Revised" License
202 stars 17 forks source link

fix midi out for newly created projects #206

Open maks opened 3 months ago

maks commented 3 months ago

@democloid ok I think it should be ready for review now.

RAWJUNGLE commented 3 months ago

@democloid this fix causes a bug with the instruments

democloid commented 3 months ago

@democloid this fix causes a bug with the instruments

@RAWJUNGLE you'll have to explain what the bug is, I'm not an mind reader

RAWJUNGLE commented 3 months ago

@democloid For example, if I create a chain, a phrase, put an instrument and click to select another instrument I get a midi channel at once, that is, I go I00 to I01, a midi channel appears, and if I want to switch back somehow, the tracker freezes, and so on and so forth.

It doesn't matter if it's an old project or a new one, it's useless.

democloid commented 3 months ago

@democloid For example, if I create a chain, a phrase, put an instrument and click to select another instrument I get a midi channel at once, that is, I go I00 to I01, a midi channel appears, and if I want to switch back somehow, the tracker freezes, and so on and so forth.

It doesn't matter if it's an old project or a new one, it's useless.

I can't reproduce this. Are you working on the latest master of this repo?

Please try the image that resulted from this PR and tell me if it still happens: https://github.com/democloid/picoTracker/actions/runs/9399675824/artifacts/1574738978