xirsoi / ancientreligions

Ancient Religions mod for CK2
15 stars 12 forks source link

CoAs and Flags #19

Closed jbelig closed 9 years ago

jbelig commented 9 years ago

Quick review: I already have decent sets for Celtic and Hellenic and will create Egyptian probably within next week (work permitting). I did a quick search and there's plenty of option for egyptians, so won't take long. My main issue is the frames, especially the map ones. Celtic is rather easy, norse graphics work for them. Egyptians I believe should use the muslim ones. I'm not sure about the character view with that, will check how it looks later. Now about hellenic... I've already worked with fixing them for using the christian graphics. The map view is a bit meh, the character view is going in a good direction. Again, muslim is an interesting option for the map and I can recustomize the character frame to make it distinct, so I'm open to suggestions. Here's what I'm working for character view frame (hellenic) right now: frame_hellenic

rquinio commented 9 years ago

Hi jbelig,

Looks awesome, but I'm not sure if the title shield frame in character view are actually moddable per religion... :/ It seems hardcoded per vanilla religion group, in generalstuff.gfx:

maskedShieldType = {
        name = "GFX_shield_big_pagan"
        textureFile1 = "gfx\\interface\\shield_big_overlay_pagan.tga"
        textureFile2 = "gfx\\interface\\shield_big_mask_pagan.tga"
        effectFile = "gfx/FX/maskedflag.lua"
        clicksound = generic_click_04
    }

For the map ones, it is based on graphical_culture of the religion set in ACR_ancient_religions.txt:

New stuff seems modable via mapitems.gfx, but would need to be tested:

EMFXActorType = {
        name = "norsegfx_count_shield"
        actorfile = "gfx\models\Shields\norse_count_shield.xac"
        scale = 0.27f
        use_animation = no
}
jbelig commented 9 years ago

Yeah, I'm aware of those files but it seems that they all refer to a frame.dds file. I've got it working in game already and it changes all relevant icons. Diplomacy screen, claims etc. I created a new type in coat_of_arms.gfx so that this frame doesn't apply to other religions. What I cannot change, is the wooden pagan background and related things like the green circle on strong claim icon. The only way to change that would be to move hellenic out of the pagan group, which is an idea worth considering in fact. Apart from the graphical issues, it is a pre-reformed religion and it seems right that they would view other pagans as barbarians. Maybe with exceptions for egyptians and zunists. Not sure what problems would be caused by creating a new religion group though.

jbelig commented 9 years ago

On a side note, I tested the zoroastrian layout and though on map the frame looks rather fitting, the interface with the green and muslim-style decorated buttons look odd for hellenism. Still would be fine for egyptians though

jbelig commented 9 years ago

Here's how it looks in game. Some allignement issues are cause by arko interface. It looks better with the vanilla one. 2015-01-18_00001 2015-01-18_00002 In the second image, notice the black area on the coa of Sozopolis? That's a vanilla coa, I've fixed this issue for my own. It seems that the same problem goes for christian and pagan vanilla custom coas. It's not easily noticeable, cause most provinces have their own flags and don't use custom ones.

rquinio commented 9 years ago

Ok, I didn't know this was possible !

I don't know if there are any hardcoded features/behaviors in pagan_group useful for pre-reformed religions. I remember in the old forum thread that superskierpat tried it for hellenic_pagan but finally gave up.

xirsoi commented 9 years ago

I've been considering moving hellenic and kemetic out of the pagan_group, since it doesn't really offer anything for them (except being the target of missionaries and pagan subjugations cbs). Super was considering moving them into the Zoroastrian Group and changing its (the group's) localisation to "Classical Religions." schwarherz has warned me against it, believing it to be too confusing. I'd deferred to his greater experience for now, but thought I should mention it.

jbelig, I like that frame quite a bit! It seems slightly flat though, could you add an outline to the inner part of the frame? It would help make the actual CoA stand out more.

Also, would you consider making the CoA's look like banners? I have no idea how that would work, but I feel like it would look great with the columns and leaves.

jbelig commented 9 years ago

Well, I could try moving the religions to a different group and see how it works while you work on other things. I have no idea about the missionaries, but I believe the pagan subjugation cb can be easily fixed. About the coa, I will explain my issues in a separate post in a while, got to run right now.

schwarherz commented 9 years ago

To be completely fair, there is no reason you couldn't make an ancient_pagan_group or something like that which operates independently of the pagan_group or the zoroastrian_group. The only potential issue I can see is I don't think there's a way to give the new group access to any other GUI, I THINK new groups default to the christian GUI (with the bishop lists), though I could be mistaken on both counts.

schwarherz commented 9 years ago

I would like to say though: these look REALLY good, do you mind if CK2Plus uses them as well?

jbelig commented 9 years ago

Here's what's going on with CoAs. The default mask is this: plain If it stays like that, you'll get the black area that you see in Sozopolis (some posts above) on the map coa, but the character coa will be fine. To cover that black thingy, I changed it to this: plain_hellenic Now, the default frame is: frame This is smaller than the mask, which means the background colour of the coa exceeds the limits of the frame and it looks very ugly. I enlarged the frame, and it resulted in some clipping at the edges so I thought I'd cover it up with the columns and the wreath. So, my frame now is precisely at the limits of the drawing area. If I want to put an outer design to make it banner like, I'll have to reduce the size of the frame, while I cannot reduce the size of the inside mask (cause it will mess my map coas again). This might make the coa emblems clip under the frame. Same thing more or less goes for the inside outliner though I do agree something is needed there. Having said all that, it's not exactly finished yet so I will try how your suggestion work.

jbelig commented 9 years ago

By the way, the same problem exists for celtic coas as well, so I was currently working on a similar workaround for them. This is what I got so far, though it's wip and I'm looking for better options: frame_celtic

jbelig commented 9 years ago

Schwarherz, thank you for your comment. I have no problem if you use it as long as stormweaver is ok with it. What you say about new religion groups makes sense, so I'm tending to vote for moving them into the zoroastrian. Are the zunists already there? I suppose they should also be at the same.

xirsoi commented 9 years ago

If its going to be a pain, don't worry about it. Zunists are in the Pagan Group, which makes sense, because they have a reformation.

jbelig, you're the artist, you get to decide who can use your stuff :+1:

jbelig commented 9 years ago

I've done some more work on hellenic frame. Couldn't find a decent way to make it banner-like I'm afraid, but I tried to make the coa stand out of the frame a bit. I enhanced the vanilla lens effect which makes it look a bit more 3d. Also, I sharpened the frame so the lines are clearer. Here's what I got now, hope you can see the differences: 2015-01-18_00003

jbelig commented 9 years ago

I also looked at the interface graphics for different religion groups and it seems it's easy to customize them. I figured that since the idea is to have zoro, egyptian and hellenic in the same group, there's no need to make a new since we have the zoro template ready. I already tried to move hellenic there and the only problem was that I was getting the decisions for restoring the zoro high church, but that should be easy to fix as well. Anyway, I'll try to customize zoro interface to fit the other 2 inside as well. I do need a couple of ideas though. First issue is the symbol for religion tab/piety. Currently it's this one: topbar_folder_religion I need a more universal symbol. Second is the colour of the buttons. Currently they're green (see image again). Could change them to default christian blueish, but I was thinking something more silver or probably better gold.

xirsoi commented 9 years ago

I'm going to open a new issue to discuss moving Hellenic and Kemetic into a different religion group.

I'm liking your progress so far, its looking great! One thing though, the CoA's themselves look like they are using a lower resolution than the frames and the vanilla CoAs.

jbelig commented 9 years ago

Actually I had to reduce the resolution of most of them to make it the same with the default ones (72 ppi). I wanted to try to leave them at something like 300ppi and see if the game will adjust them properly, thanks for reminding. Also, most of the hellenic ones came from ancient statues, wall paintings, amphoras. What I had to do is change their actual colours to plain red, green, blue so that they'll work with the customizer colour picker. Some of them came off a little 'cloudy' after that procedure and I intend to either fix or get rid of those ones.

jbelig commented 9 years ago

Just for comparison, here's the current full hellenic set and one of the vanilla coa sets:

hellenic_pack

pattern4

xirsoi commented 9 years ago

jbelig, those look great. I noticed in generalstuff.gfx that it references several different sizes for frames and shields (small, medium, and big). Could that be part of your alignment issues?

Also, I would recommend talking to Arko and/or AnaxXiphos to see if they have any ideas. They are pretty much the modding communities resident experts on the graphical side of things.

jbelig commented 9 years ago

Yeah, I've seen the different sizes in this file and I still haven't figured out why they're there. It seems that the frame.dds and plain.tga files that exist in gfx/coats_of_arms do all the job. Perhaps if I modify the other files they will override those now that I think of it, so I'm going to try that. I haven't been able to do anything the past couple of days due to work, but I will probably have some free time from this afternoon on. I have already asked Arko by the way, he gave an idea that didn't work for me but I suspect that he didn't understand exactly what my issue was. That said, I know that in his pack he did exactly the same work for the round pagan coas that have the same problem.

jbelig commented 9 years ago

I just tried tweaking the files that generalstuff.gfx refers to. They define the sizes for normal flags, not coas. That gave me an idea though. After I'm done with all coas, I'll make some fixed flags for select provinces if they happen to turn hellenic (or celtic or whatever). Now I was thinking, what I'm doing here will raise compatibility issues with other mods and it will increase the size of the mod download quite a bit. Do you think I should build that as an optional sub-mod instead of including it in the standard download?

rquinio commented 9 years ago

What kind of compatibility issues ? For changing the flag of a title dynamically, there is this new set_coa command which might be useful:

k_italy = {
  set_coa = k_lombardy
}
jbelig commented 9 years ago

Well, I basically had ARKOpack in mind cause I always play with that. On second thought it's not really important though, since we're going to mess this up anyway if we change religious groups

xirsoi commented 9 years ago

If we change the religion groups. We still don't know if its the best idea.

jbelig commented 9 years ago

I know, I know

jbelig commented 9 years ago

I've spent the last couple of days polishing the hellenic coas. I've replaced some, doubled resolution and fixed some others. So here's the final version since I've reached the limits of my graphic potential...

hellenic_pack

xirsoi commented 9 years ago

They're gorgeous, good work :+1:

jbelig commented 9 years ago

I'm almost done with egyptian coas. All I need to do is resize and tweak them, and I really need an opinion for that. Are we going to use africangfx as ck2+ or change it to muslimgfx? Here they are for a quick comparison. Note that the coas on screens are the default ones and that the black circle you see in africangfx screen will be fixed anyway.

2015-01-28_00001

2015-01-28_00002

Another small note. The horses on africangfx empire border are not really unfitting for ancient egyptians, since they had chariot archers as their signature military unit.

jbelig commented 9 years ago

Still need a lot of work (see previous post), but here's a preview of the Kemetic pack:

kemetic_pack

rquinio commented 9 years ago

For the map (i.e. religion graphical_culture), I'd say africangfx to easily differentiate pagans from muslims. For the other screens which template will you use as basis ? The pagan round/plain one ?

rquinio commented 9 years ago

Btw, both patterns look awesome :)

jbelig commented 9 years ago

Well, either way I'll have to go with a round template, both muslim and pagan use that one. I was thinking of using the muslim frame for the other screens (hexagonal), but I have to see how the image will fit in once I scale it in order to fix the black circle. Africangfx does indeed stand out in this area of the map, and it's my favourite frame generally, but personally I lean towards the muslim for this one. The decoration seems more fitting. One vote remaining I guess :)

jbelig commented 9 years ago

And since we're on a voting procedure, what do you think of this celtic frame?

2015-01-28_00005

I'd also like a final opinion about the hellenic frame I've made (scroll a bit above). Though I loved it at first, I'm having second thoughts that it might be too much.

xirsoi commented 9 years ago

I like the Celtic frame, but I also liked the old green one. I think this one will contrast better with all the green CoAs we'll be seeing though.

I prefer the African frame over the Muslim one for Egyptian Pagan.

I'm tending to agree on the Hellenic CoA being a bit much, now that I've been looking at it for a while. I really like the laurel on the bottom, but perhaps you could do something different with the sides and top?

Btw, I work from 8-5 Central U.S. time and can't log in to github in that time. I know rquinio is in France, so we likely won't be able to collaborate in real time often.

jbelig commented 9 years ago

African it is then! I like the laurel too, so I've already reworked it to this one:

frame_hellenic

Regarding the celtic frame, I have a fear that it might also be a bit much so there's the option without the corners:

frame_celtic12

rquinio commented 9 years ago

Perfect for Hellenic ! Yeah, I agree the squarish Celtic frame looks a bit heavy, a more circular shape fits better. I don't know if snake symbol could fit ? snake Also I liked the original greenish CoA you did too :)

jbelig commented 9 years ago

Ah, ouroboros. This one is actually universal. I've found the specific image in norse, celtic, egyptian and hellenic pages... In fact, I was considering it for kemetic.

jbelig commented 9 years ago

Ok, I tried the green celtic frame again and it doesn't work. I need something more solid to cover the colour of the coa that exceeds the original frame. I did something else though that I like quite a bit:

2015-01-29_00008

I like that it blends well into the original frame while still giving a clear celtic feel. Now the kemetic, it's going to be a real pain...

jbelig commented 9 years ago

Now that I see the image here, it looks a bit off, but that's not the case in game. On the upper side of the circular old frame, there's a brown lining which is from the original. On the lower side, this line is much darker and not quite visible here. If you see the whole thing in game it looks as one piece.

jbelig commented 9 years ago

Well, that was a lot quicker than I expected. I came up with a kemetic frame, which is from an actual ancient egyptian tombstone. In full resolution you can see the hieroglyphics on it, but not at the game size and res I'm afraid. Anyway, here it is:

2015-01-29_00014

rquinio commented 9 years ago

I like it !

xirsoi commented 9 years ago

As do I!

As for the Celtic frame, I prefer the gold chain look you had before. In fact, I prefer the version with corners even more, but it seems I've been out voted ;)

jbelig commented 9 years ago

I can try a compromise, the gold chain with just the upper corners maybe, see how it looks. The one with the 4 corners is a bit heavy in game, especially on screens were you get lots of them in line.

xirsoi commented 9 years ago

Actually, the thing I like the least about your newest Celtic frame is that its top heavy. Could you show us what it looks like to have several of the "cornered chain" frames in a row? In game I mean.

jbelig commented 9 years ago

Sure thing, here it is:

2015-01-30_00001

And here's why it had to be top heavy. When I resize the mask to make it fit better in the map frame I get this 'flooding' colour on other screens (see the red at the top? ). The golden chain frame solves the issue even without the corners though.

2015-01-30_00002

xirsoi commented 9 years ago

I can see now how the cornered chain frame is a bit too much. I prefer the chain frame myself.

jbelig commented 9 years ago

All packs are ready. Here's the finished celtic one:

celtic_pack

Since I still can't fix stuff on github, I'll email them tomorrow in a zip with all folders arranged. I'm altering 2 files that are already in the mod, ACR_ancient_religions.txt and coat_of_arms.txt. Are there any recent alterations to those files? Should I just get the ones from develop branch and modify them? I'll probably fix the whole thing early tomorrow since it's 3 AM here already and I have a work appointment in the morning (no Sundays for me... )

EDIT: Duh, just saw you posted the newest update on forums earlier, so I'll work with those files.

jbelig commented 9 years ago

Forgot to mention that I'm going with the golden chain celtic frame for now. If I come up with a better idea later, it's just one little file.

xirsoi commented 9 years ago

If its not too late, please use the latest develop branch.

Also, those CoAs are beautiful!

jbelig commented 9 years ago

I was merging my coas and came across an unexpected problem. It seems that has_coa_on_barony_only=no is referring to whole groups only and not separate religions. The default for pagan group is yes and if I set it to no in our own religions file it changes coas for all pagan provinces in game and gives them random ones. That alone can be an issue for some players if they prefer to use specific flags, but also causes the nasty black circles to appear on map (this can be fixed though with only a couple additional tga files). On the other hand, I'd hate to see my coas used only for dynasties and have provinces keep their old christian or muslim ones. It does look awkward to be a hellenic byzantine emperor with Zeus as your dynasty emblem and the cross as your realm flag... I tried to set a different value for each pagan religion but it didn't work, so it's either all random coas or all fixed flags. Opinions? Votes?