search

xirsys / xirsys-examples-v3

Xirsys Examples for V3 API
24 stars 27 forks source link

xirsys-signal.js sendMessage: wrong "f"-value? #11

Open Florrr opened 4 years ago

Florrr commented 4 years ago

I just noticed that you are using this.channelPath + this.userName as the f-value for messages: https://github.com/xirsys/xirsys-examples-v3/blob/d715dc1c993069c5366940de524a3aef73ab08c7/app/public/lib/xirsys-signal.js#L212 But that did not work for us when the channelPath is non-empty.

The problem with this is, that the receiver does not recognize the leading channel since there is no trailing slash ("/"): https://github.com/xirsys/xirsys-examples-v3/blob/d715dc1c993069c5366940de524a3aef73ab08c7/app/public/lib/xirsys-signal.js#L167

Therefore I've change the f-value to this.channelPath + "/" + this.userName

Am I doing something wrong, or is this a bug in your library?