Go v1.22 cannot detect PAR_GO_PATH_DELIMITER as "."

xitongsys / parquet-go

pure golang library for reading/writing parquet file

Apache License 2.0

1.25k stars 294 forks source link

Go v1.22 cannot detect PAR_GO_PATH_DELIMITER as "." #586

Open nhidh99 opened 3 months ago

nhidh99 commented 3 months ago

https://github.com/xitongsys/parquet-go/blob/75e935fc3e17e62c3e4ae5e088b84c8af47a23b0/common/common.go#L974

I have upgraded my Go project to go version 1.22, and it breaks when read parquet file.

After a long trace, I found out go v1.22 cannot understand "\x01" as string dot ".", it returns empty string "" instead.

Can we have a change to define PAR_GO_PATH_DELIMITER = "." for readability and also prevent this issue?

robertino commented 2 months ago

After a long trace, I found out go v1.22 cannot understand "\x01" as string dot ".", it returns empty string "" instead.

why would you expect "\x01" to be a "."? a dot would be "\x2E" according to ASCII table, and "\x01" is not a printable character (hence "" I guess) that's SOH (^A)