xiv-gear-planner / gear-planner

xivgear.app
https://xivgear.app/
18 stars 17 forks source link

Fix bug relating to auto-attacks not applying by changing cache key for sims #423

Closed VioletHynes closed 1 week ago

VioletHynes commented 1 week ago

Since the decision to use autos is decided by: useAutos: (this.cycleSettings.useAutos ?? true) && set.getItemInSlot('Weapon') !== null, and we can't use autos without a weapon, this causes an issue when you make a new set and then add a weapon, as the sim won't use autos since it was created without a weapon (as all sets are).

Without considering this a new set for the cache, the old rotation will be used, which won't include auto-attacks (we don't know how to do auto-attacks without a weapon).

VioletHynes commented 1 week ago

Superseded by https://github.com/xiv-gear-planner/gear-planner/pull/424