xiv-gear-planner / gear-planner

xivgear.app
https://xivgear.app/
18 stars 17 forks source link

Enhancement: Typed Haste #431

Open raineaeternal opened 4 days ago

raineaeternal commented 4 days ago

While I was looking into Riddle of Wind for the Monk sim, I found that combinedEffects.haste and potentially stats.bonusHaste("Auto-Attack) does not accurately implement different types of haste. The problem this causes is that Monk damage will be inflated on the sim as a result, these should be checked for their haste type.

AkhMorning outlines Greased Lightning to be a Type Z buff, while Riddle of Wind appears to be a Type Y buff. Monk is so far the only job to interact with this kind of buff shenanigans and more testing and research would be needed to accurately prove this. from my limited testing, however, it seems to be that the FFLogs estimate only produces a 0.03s disparity between RoW and non-RoW Auto Attack Delays. (This may be due to how the auto attack functions in game.)

This work would also benefit other jobs, like Black Mage and other jobs with conditional haste buffs. (ex. Leylines)

If you need more data, or just have a chat about this, do feel free to @ me in The Balance, or dm me; raineaeternal