xivSolutions / biggy

A File-based Document Store for .NET
BSD 3-Clause "New" or "Revised" License
131 stars 24 forks source link

Inflector dependency incompatible with WP8.1 #23

Open treitmaier opened 9 years ago

treitmaier commented 9 years ago

When I try to add Biggy.Core to a blank Windows Phone 8.1 project using nuget, I get the following error:

PM> install-package biggy.core
Attempting to resolve dependency 'Inflector (≥ 1.0.0.0)'.
Attempting to resolve dependency 'Newtonsoft.Json (≥ 6.0.6)'.
Installing 'Biggy.Core 0.1.0.1'.
Successfully installed 'Biggy.Core 0.1.0.1'.
Install failed. Rolling back...
install-package : Could not install package 'Inflector 1.0.0.0'. You are trying to install this package into a project that targets 'WindowsPhoneApp,Version=v8.1', but the package does not contain any assembly 
references or content files that are compatible with that framework. For more information, contact the package author.
At line:1 char:1
+ install-package biggy.core
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Install-Package], InvalidOperationException
    + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PowerShell.Commands.InstallPackageCommand

A quick search through the source code, revealed that Biggy only makes use of the Inflector library to pluralize names, e.g:

this.TableName = Inflector.Inflector.Pluralize(typeof(T).Name.ToLower());

Would you consider using a library that supports WP 8.1, such as Humanizer. Changes to the code should be fairly straightforward:

this.TableName = Humanizer.InflectorExtensions.Pluralize(typeof(T).Name.ToLower());

Thanks!

Thomas

xivSolutions commented 9 years ago

Hey there -

Thanks for the feedback!

I'll take a look at it as soon as I can. We definitely want to be cross-platform as widely as possible.