search

xivdev / Penumbra

FINAL FANTASY XIV modding, but actually good this time
589 stars 114 forks source link

Add alternative link format for repository validation #346

Closed Kamil118 closed 8 months ago

Kamil118 commented 9 months ago

There are multiple valid URLs that can access the same raw file on Git Hub. If somebody used the URLs added in this commit they would get a validation error despite using an approved repository.

In particular, I found an issue when adding SeaOfStars repository through UnknownX7's plugin repository browser. While it's something that could be fixed on their end in the repo manifest list, I do believe that it's a validation error (False negative validation) that should be addressed here.

Ottermandias commented 9 months ago

I actually kinda do want people to use those explicit links, not equal-but-different ones, because people are also supposed to read tutorials/guides/instructions and follow them.

Kamil118 commented 9 months ago

I see.

I personally have to disagree and think that users should be able to use a configuration that is logically valid but right now is only rendered invalid because of excessively strict validation.

But I guess I won't be the one who will do tech support on Discord for somebody who tried to install the plugin on their own but somehow managed to screw up. I personally found the process pretty idiot-proof to the point there is no need for guides, but I guess I should never underestimate the user.

I don't really have anything else to add. If you think it's an unwanted change feel free to close the pull request.

That being said, the current error message for an invalid repository URL is a bit unwieldy. I would suggest either having an option to copy an approved repo URL (Since right now it has to be copied to the repo list by hand) or if you really don't want users to install the plugin without using a guide, have a clickable link to an "approved" installation guide.