xivdev / Penumbra

FINAL FANTASY XIV modding, but actually good this time
581 stars 114 forks source link

.mdl io: Move vertex colours onto custom attribute. #388

Closed ackwell closed 5 months ago

ackwell commented 5 months ago

Title. What this PR should have been: like one string change and a dictionary lookup. What it is: like, 250 lines of copy pasta, because the gltf lib decided to implement custom attributes as an extension of materials.

If anyone's got a better idea, please lemme know. The lib handles this with generated (repetitive) code.

In future, I'll likely overhaul the export pipeline to handle attributes directly and bypass this, as doing that will be really helpful for other planned features - but that's all a fair time out.