Describe the bug
I've been using old log files, and I admit it now. I'm the bug in this particular mess. It looks like act has moved from md5 -> sha512 and only uses the first 16 bytes of the resultant checksum for validation.
To Reproduce
Use anything from the head of event-rewrite with a modern log file and checksum validation turned on:
from nari.io.reader.actlog import ActLogReader
for event in ActLogReader(log_file_path, raise_on_checksum_failure=True):
pass
Expected behaviour
That the above snipped executes with zero failures.
Additional context
Ax has been showing me rust and getting me addicted, please make him stop.
nonowazu
commented
2 years ago
Describe the bug I've been using old log files, and I admit it now. I'm the bug in this particular mess. It looks like act has moved from md5 -> sha512 and only uses the first 16 bytes of the resultant checksum for validation.
To Reproduce Use anything from the head of event-rewrite with a modern log file and checksum validation turned on:
Expected behaviour That the above snipped executes with zero failures.
Additional context Ax has been showing me rust and getting me addicted, please make him stop.