search

xixip / google-glog

Automatically exported from code.google.com/p/google-glog
Other
0 stars 0 forks source link

Installed failure signal handler should not include SIGTERM #139

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. call InstallFailureSignalHandler()
2. kill the process with SIGTERM(15)
3. glog print callstack, and then quit.

What is the expected output? What do you see instead?
from sigal(7), the default action of SIGTERM is just quit, without core dump.
Man operation script kill the process with SIGTERM, the call stack here 
misguide the users.

       Signal     Value     Action   Comment
       -------------------------------------------------------------------------
       SIGHUP        1       Term    Hangup detected on controlling terminal
                                     or death of controlling process
       SIGINT        2       Term    Interrupt from keyboard
       SIGQUIT       3       Core    Quit from keyboard
       SIGILL        4       Core    Illegal Instruction
       SIGABRT       6       Core    Abort signal from abort(3)
       SIGFPE        8       Core    Floating point exception
       SIGKILL       9       Term    Kill signal
       SIGSEGV      11       Core    Invalid memory reference
       SIGPIPE      13       Term    Broken pipe: write to pipe with no readers
       SIGALRM      14       Term    Timer signal from alarm(2)
       SIGTERM      15       Term    Termination signal

What version of the product are you using? On what operating system?
2.0, Linux

Please provide any additional information below.
I removed SIGTERM from kFailureSignals, see diff FYI.

Original issue reported on code.google.com by chen3feng on 5 Dec 2012 at 12:03

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for your patch! Could you sign our Individual Contributor License 
Agreement, 
please? We need to ask you to sign this to avoid any troubles. The process is 
just 
submitting an HTML form, and it shouldn't take your time so much.

http://code.google.com/legal/individual-cla-v1.0.html

Sorry for the latency...

Original comment by shinichi...@gmail.com on 20 Dec 2012 at 9:05

GoogleCodeExporter commented 9 years ago 
Get at Me

Original comment by 323lill...@gmail.com on 19 Apr 2015 at 6:05

GoogleCodeExporter commented 9 years ago 
I've already signed several years ago.

Agreement   Name    Date Signed Manage
Google Individual CLA   Chen Feng   Dec 23, 2012 17:48 PST  Edit Contact Information

Original comment by chen3feng on 27 Apr 2015 at 6:37