xizzhu / Joshua

A simple and easy-to-use Bible reader.
https://xizzhu.me/pages/about-joshua/
Apache License 2.0
39 stars 12 forks source link

Refactor StrongNumber Activity / ViewModel to use single view state #237

Closed xizzhu closed 2 years ago

xizzhu commented 2 years ago

Essentially part of https://github.com/xizzhu/Joshua/pull/233, which is too big to manage.

codecov-commenter commented 2 years ago

Codecov Report

Merging #237 (af4786a) into master (d83a067) will increase coverage by 0.09%. The diff coverage is 35.54%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   52.74%   52.83%   +0.09%     
==========================================
  Files         122      125       +3     
  Lines        4609     4705      +96     
  Branches      605      618      +13     
==========================================
+ Hits         2431     2486      +55     
- Misses       2105     2145      +40     
- Partials       73       74       +1     
Impacted Files Coverage Δ
.../main/kotlin/me/xizzhu/android/joshua/Injection.kt 0.00% <0.00%> (ø)
...android/joshua/core/CoroutineDispatcherProvider.kt 0.00% <0.00%> (ø)
...n/me/xizzhu/android/joshua/infra/BaseActivityV2.kt 0.00% <0.00%> (ø)
...ndroid/joshua/strongnumber/StrongNumberActivity.kt 0.00% <0.00%> (ø)
.../main/kotlin/me/xizzhu/android/joshua/ui/Dialog.kt 0.00% <0.00%> (ø)
...e/xizzhu/android/joshua/preview/PreviewViewData.kt 96.77% <87.50%> (+20.91%) :arrow_up:
.../me/xizzhu/android/joshua/infra/BaseViewModelV2.kt 100.00% <100.00%> (ø)
...droid/joshua/strongnumber/StrongNumberViewModel.kt 98.70% <100.00%> (+12.65%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more