xizzhu / Joshua

A simple and easy-to-use Bible reader.
https://xizzhu.me/pages/about-joshua/
Apache License 2.0
39 stars 12 forks source link

Refactor ReadingProgress Activity / ViewModel to use single view state #240

Closed xizzhu closed 1 year ago

xizzhu commented 1 year ago

Essentially part of https://github.com/xizzhu/Joshua/pull/233, which is too big to manage.

The refactoring to use ListAdapter is to eventually eliminate the usage of the custom CommonRecyclerView.

codecov-commenter commented 1 year ago

Codecov Report

Merging #240 (9fc9e9b) into master (4be63ab) will increase coverage by 1.29%. The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   53.98%   55.27%   +1.29%     
==========================================
  Files         123      123              
  Lines        4883     4937      +54     
  Branches      649      657       +8     
==========================================
+ Hits         2636     2729      +93     
+ Misses       2176     2138      -38     
+ Partials       71       70       -1     
Impacted Files Coverage Δ
...ndroid/joshua/annotated/AnnotatedVersesActivity.kt 0.00% <0.00%> (ø)
...n/me/xizzhu/android/joshua/infra/BaseActivityV2.kt 0.00% <0.00%> (ø)
...android/joshua/progress/ReadingProgressActivity.kt 0.00% <0.00%> (ø)
.../me/xizzhu/android/joshua/search/SearchActivity.kt 0.00% <0.00%> (ø)
...ndroid/joshua/strongnumber/StrongNumberActivity.kt 0.00% <0.00%> (ø)
.../android/joshua/progress/ReadingProgressAdapter.kt 41.66% <41.66%> (ø)
...ndroid/joshua/progress/ReadingProgressViewModel.kt 100.00% <100.00%> (+8.51%) :arrow_up:
...zzhu/android/joshua/progress/ReadingProgressBar.kt 37.25% <0.00%> (+37.25%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more