search

xizzhu / Joshua

A simple and easy-to-use Bible reader.
https://xizzhu.me/pages/about-joshua/
Apache License 2.0
39 stars 12 forks source link

Refactor TranslationsActivity / ViewModel to use single view state #251

Closed xizzhu closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #251 (b0b14d8) into master (1af253e) will increase coverage by 1.22%. The diff coverage is 76.68%.

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   68.83%   70.05%   +1.22%     
==========================================
  Files         121      121              
  Lines        5387     5550     +163     
  Branches      705      740      +35     
==========================================
+ Hits         3708     3888     +180     
+ Misses       1583     1545      -38     
- Partials       96      117      +21
Impacted Files Coverage Δ
...android/joshua/annotated/AnnotatedVerseActivity.kt 84.84% <0.00%> (ø)
...android/joshua/progress/ReadingProgressActivity.kt 85.00% <0.00%> (ø)
.../me/xizzhu/android/joshua/search/SearchActivity.kt 82.95% <0.00%> (ø)
...ndroid/joshua/strongnumber/StrongNumberActivity.kt 81.81% <0.00%> (ø)
...xizzhu/android/joshua/settings/SettingsActivity.kt 58.11% <33.33%> (-0.66%) :arrow_down:
...ndroid/joshua/translations/TranslationsActivity.kt 43.80% <42.00%> (+43.80%) :arrow_up:
...e/xizzhu/android/joshua/core/TranslationManager.kt 14.28% <50.00%> (-10.72%) :arrow_down:
.../android/joshua/annotated/AnnotatedVerseAdapter.kt 99.25% <83.33%> (-0.75%) :arrow_down:
...droid/joshua/translations/TranslationsViewModel.kt 99.18% <99.06%> (+11.68%) :arrow_up:
...ndroid/joshua/annotated/AnnotatedVerseViewModel.kt 99.32% <100.00%> (ø)
... and 5 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more