xizzhu / Joshua

A simple and easy-to-use Bible reader.
https://xizzhu.me/pages/about-joshua/
Apache License 2.0
39 stars 12 forks source link

Refactor reading toolbar and chapter selection view #252

Closed xizzhu closed 1 year ago

xizzhu commented 1 year ago

It is a preparation for refactoring the ReadingActivity.

codecov-commenter commented 1 year ago

Codecov Report

Merging #252 (ce6e9c2) into master (56d4084) will increase coverage by 2.39%. The diff coverage is 61.01%.

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   70.05%   72.45%   +2.39%     
==========================================
  Files         121      122       +1     
  Lines        5550     5576      +26     
  Branches      740      759      +19     
==========================================
+ Hits         3888     4040     +152     
+ Misses       1545     1406     -139     
- Partials      117      130      +13     
Impacted Files Coverage Δ
...e/xizzhu/android/joshua/reading/ReadingActivity.kt 0.00% <0.00%> (ø)
.../search/FloatingActionButtonScrollAwareBehavior.kt 0.00% <0.00%> (ø)
...oid/joshua/reading/chapter/ChapterSelectionView.kt 65.90% <66.66%> (+65.90%) :arrow_up:
...oshua/reading/toolbar/TranslationSpinnerAdapter.kt 87.50% <86.11%> (+71.28%) :arrow_up:
...u/android/joshua/reading/toolbar/ReadingToolbar.kt 88.33% <90.00%> (+28.71%) :arrow_up:
...droid/joshua/reading/chapter/ChapterListAdapter.kt 92.15% <92.15%> (ø)
.../android/joshua/reading/chapter/ChapterListView.kt 89.28% <94.73%> (+89.28%) :arrow_up:
... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more