xizzhu / Joshua

A simple and easy-to-use Bible reader.
https://xizzhu.me/pages/about-joshua/
Apache License 2.0
39 stars 12 forks source link

Introduce ChapterSelectionFragment / ViewModel #254

Closed xizzhu closed 1 year ago

xizzhu commented 1 year ago

It is a preparation for refactoring the giant ReadingActivity.

codecov-commenter commented 1 year ago

Codecov Report

Merging #254 (125e3eb) into master (b5b46b0) will increase coverage by 0.44%. The diff coverage is 84.44%.

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
+ Coverage   75.64%   76.09%   +0.44%     
==========================================
  Files         125      126       +1     
  Lines        5700     5743      +43     
  Branches      774      777       +3     
==========================================
+ Hits         4312     4370      +58     
+ Misses       1242     1228      -14     
+ Partials      146      145       -1     
Impacted Files Coverage Δ
...e/xizzhu/android/joshua/reading/ReadingActivity.kt 20.51% <0.00%> (+0.18%) :arrow_up:
...joshua/reading/chapter/ChapterSelectionFragment.kt 77.27% <77.27%> (ø)
...droid/joshua/reading/chapter/ChapterListAdapter.kt 91.66% <86.66%> (-0.50%) :arrow_down:
...oshua/reading/chapter/ChapterSelectionViewModel.kt 96.96% <96.96%> (ø)
.../android/joshua/reading/chapter/ChapterListView.kt 90.62% <100.00%> (+1.33%) :arrow_up:
...oid/joshua/reading/chapter/ChapterSelectionView.kt 72.72% <100.00%> (+4.54%) :arrow_up:
...d/joshua/reading/toolbar/ReadingToolbarFragment.kt 68.96% <100.00%> (ø)
.../xizzhu/android/joshua/core/BibleReadingManager.kt 79.59% <0.00%> (+2.04%) :arrow_up:
.../main/kotlin/me/xizzhu/android/joshua/Injection.kt 88.46% <0.00%> (+3.84%) :arrow_up:
... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more