xjiang4 / ellipsoids

Automatically exported from code.google.com/p/ellipsoids
Other
0 stars 1 forks source link

Make ellipsoid.rho accept the multi-dimensional arrays of directions #106

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Two problems:

1) rho doesn't throw a proper exception for the case when both ellArr and 
dirMat contain multiple elements.  

2) A case of ellArr and dirArr being multi-dimensional like

ellArr: ellipsoid[nDim1,nDim2,...,nDimk]
dirArr: double[nDim1,nDim2,...,nDimk,nDims]

where nDims stands for dimensionality of ellipsoids.

We need to fix 1),2) and write tests.

Original issue reported on code.google.com by heartofm...@gmail.com on 17 Apr 2013 at 5:28

GoogleCodeExporter commented 8 years ago

Original comment by heartofm...@gmail.com on 26 Apr 2013 at 7:13

GoogleCodeExporter commented 8 years ago

Original comment by vetba...@gmail.com on 27 Apr 2013 at 10:26

GoogleCodeExporter commented 8 years ago

Original comment by heartofm...@gmail.com on 28 Apr 2013 at 9:54

GoogleCodeExporter commented 8 years ago
Some questions to comments:
1.But bpMat is a matrix 
double [nDim,nDims1*nDims2*...*nDimsN]
2. About vectorized. Here directions may be an Array not Matrix as in Ilya's 
branch. So I can't vectorize like there.
3. About profile. What exactly should I do with it, just see or something else?

Original comment by vetba...@gmail.com on 28 Apr 2013 at 11:17

GoogleCodeExporter commented 8 years ago

Original comment by vetba...@gmail.com on 28 Apr 2013 at 1:30

GoogleCodeExporter commented 8 years ago

Original comment by heartofm...@gmail.com on 28 Apr 2013 at 1:59

GoogleCodeExporter commented 8 years ago
There are negative tests: lines 63-75.

Original comment by vetba...@gmail.com on 28 Apr 2013 at 2:06

GoogleCodeExporter commented 8 years ago
There are negative tests: lines 63-75.

Original comment by vetba...@gmail.com on 28 Apr 2013 at 2:40

GoogleCodeExporter commented 8 years ago
Please replace "wrongSizes" with "wrongInput:wrongSizes" and then reintegrate. 
Good job.

Original comment by heartofm...@gmail.com on 28 Apr 2013 at 5:48

GoogleCodeExporter commented 8 years ago

Original comment by vetba...@gmail.com on 29 Apr 2013 at 4:03

GoogleCodeExporter commented 8 years ago

Original comment by heartofm...@gmail.com on 29 Apr 2013 at 9:02