search

xjiang4 / ellipsoids

Automatically exported from code.google.com/p/ellipsoids
Other
0 stars 1 forks source link

Make refine support multiple systems so that it can be applied after evolve #122

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Currently refine is only implemented for the case when 
numel(self.linSysCVec)==1.
We need more generic implementation (with enhanced tests) so that refine can be 
applied after evolve.

Original issue reported on code.google.com by heartofm...@gmail.com on 28 May 2013 at 11:33

GoogleCodeExporter commented 8 years ago 
1) Make refine modify a copy of the original object (like cut, evolve and other 
methods do). This can be done by using a) renaming the output from self to 
outReachObj and adding outReachobj=self.getCopy() command at the beginning of 
the method

2) Fix all tests in elltool.reach.test.mlunit.ContinuousReachRefineTestCase 
test case by replacing calls like "reachObj.evolve(..)" with 
"reachObj=reachObj.evolve(...)". After that the tests will start failing which 
is normal because refine is not implemented to work after evolve.

3) Make sure all all calls of refine everywhere in the toolbox return object 
(otherwise they are useless).

4) Implement a more sophisticated test (comparing to testRefMisc) that runs 
evolve after evolve for a different system (third input to evolve). Existing 
checks in testRefMisc only run refine after evolve run for the same system 
(without the third input to evolve). 

5)  Fix implementation of "refine" so that it can work after evolve run for a 
different system (and different set of directions).

Original comment by heartofm...@gmail.com on 9 Jun 2013 at 4:25

GoogleCodeExporter commented 8 years ago

Original comment by illumina...@gmail.com on 9 Jun 2013 at 6:06

GoogleCodeExporter commented 8 years ago

Original comment by illumina...@gmail.com on 13 Jun 2013 at 1:18

GoogleCodeExporter commented 8 years ago 
Seems ok. You can reintegrate but if some tests fail I'll have to revert your 
changes.

Original comment by heartofm...@gmail.com on 13 Jun 2013 at 7:03

GoogleCodeExporter commented 8 years ago

Original comment by illumina...@gmail.com on 13 Jun 2013 at 8:45

GoogleCodeExporter commented 8 years ago

Original comment by heartofm...@gmail.com on 14 Jun 2013 at 5:12