Closed GoogleCodeExporter closed 8 years ago
Original comment by SeregaDrozh
on 26 Oct 2013 at 11:05
From your commit I cannot understand what classes you have changed. You should
have performed two separate commits - one for 1) and one - for 2) and 3).
Right now I just cannot review your changes because I do not see them, what I
see is that you moved a bunch of classes but I do not see how those classes
were changed.
Can you either re-create your branch and make two different commits or provide
me with some other way to find the lines of code your changed?
Original comment by heartofm...@gmail.com
on 26 Oct 2013 at 1:57
Original comment by SeregaDrozh
on 26 Oct 2013 at 3:29
Have you run ALL the tests? What are the results?
Original comment by heartofm...@gmail.com
on 26 Oct 2013 at 6:26
All tests passed
Original comment by SeregaDrozh
on 27 Oct 2013 at 6:36
Original comment by heartofm...@gmail.com
on 31 Oct 2013 at 3:18
You can reintegrate if all tests pass
Original comment by heartofm...@gmail.com
on 31 Oct 2013 at 4:21
Original comment by SeregaDrozh
on 2 Nov 2013 at 4:36
Have you reintegrated? If so - please change the status to "reintegrated",
otherwise please describe what kind of feedback do you expect?
Original comment by heartofm...@gmail.com
on 3 Nov 2013 at 3:33
You can reintegrate as long as all the tests pass
Original comment by heartofm...@gmail.com
on 6 Nov 2013 at 3:23
Original comment by SeregaDrozh
on 8 Nov 2013 at 11:41
Original comment by heartofm...@gmail.com
on 12 Nov 2013 at 8:36
Original issue reported on code.google.com by
heartofm...@gmail.com
on 19 Oct 2013 at 7:10