xjiang4 / ellipsoids

Automatically exported from code.google.com/p/ellipsoids
Other
0 stars 1 forks source link

Improve matrix functions architecture #136

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
1) gras.interp.* classes returns [nRows, nTimePoints] as a result if evaluation 
if nDims == 1. But gras.mat.* classes returns [nRows, nCols, nTimePoints] as a 
result 
in all cases. We need to make unified format of result. [nRows, nCols, 
nTimePoints] 
will be better for current gras.mat.interp.* multiply operations.

To avoid bugs with the result format in gras.mat current SuiteOp compares 
evaluatedVals(:) and expectedVals(:). This isn't good - we would need to 
replace 
it with isequal(evaluatedVals, expectedVals) after the format will have been 
unified.

The only gras.interp class which have evaluation result format [nRows, nCols, 
nTimePoints] now
 is MatrixScalarCubicSpline. It's the example of the format benefits 
(the code for multiplication and division in gras.interp classes wasn't 
changed).

2) Classes in gras.mat.symb.* (and implemented in AMatrixOperations symb 
operations) 
aren't used in our project widely. We can unite them with same set operations 
in 
gras.mat.fcnlib  (and examples of non-constant tests in 
gras.mat.test.mlunit.SuiteOp proves it).

3) Move gras.interp into gras.mat.interp

Original issue reported on code.google.com by heartofm...@gmail.com on 19 Oct 2013 at 7:10

GoogleCodeExporter commented 8 years ago

Original comment by SeregaDrozh on 26 Oct 2013 at 11:05

GoogleCodeExporter commented 8 years ago
From your commit I cannot understand what classes you have changed. You should 
have performed two separate commits - one for 1) and one - for 2) and 3). 

Right now I just cannot review your changes because I do not see them, what I 
see is that you moved a bunch of classes but I do not see how those classes 
were changed.

Can you either re-create your branch and make two different commits or provide 
me with some other way to find the lines of code your changed?

Original comment by heartofm...@gmail.com on 26 Oct 2013 at 1:57

GoogleCodeExporter commented 8 years ago

Original comment by SeregaDrozh on 26 Oct 2013 at 3:29

GoogleCodeExporter commented 8 years ago
Have you run ALL the tests? What are the results?

Original comment by heartofm...@gmail.com on 26 Oct 2013 at 6:26

GoogleCodeExporter commented 8 years ago
All tests passed

Original comment by SeregaDrozh on 27 Oct 2013 at 6:36

GoogleCodeExporter commented 8 years ago

Original comment by heartofm...@gmail.com on 31 Oct 2013 at 3:18

GoogleCodeExporter commented 8 years ago
You can reintegrate if all tests pass

Original comment by heartofm...@gmail.com on 31 Oct 2013 at 4:21

GoogleCodeExporter commented 8 years ago

Original comment by SeregaDrozh on 2 Nov 2013 at 4:36

GoogleCodeExporter commented 8 years ago
Have you reintegrated? If so - please change the status to "reintegrated", 
otherwise please describe what kind of feedback do you expect?

Original comment by heartofm...@gmail.com on 3 Nov 2013 at 3:33

GoogleCodeExporter commented 8 years ago
You can reintegrate as long as all the tests pass

Original comment by heartofm...@gmail.com on 6 Nov 2013 at 3:23

GoogleCodeExporter commented 8 years ago

Original comment by SeregaDrozh on 8 Nov 2013 at 11:41

GoogleCodeExporter commented 8 years ago

Original comment by heartofm...@gmail.com on 12 Nov 2013 at 8:36