search

xjiang4 / ellipsoids

Automatically exported from code.google.com/p/ellipsoids
Other
0 stars 1 forks source link

Write tests for plotting methods of ReachContinuous/ReachDiscrete and ellipsoid classes with use of RelationDataPlotter objects #138

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Plotting methods of these classes can accept an object of 

smartdb.disp.RelationDataPlotter 

class (optionally) which is used for plotting. If this object is not passed 
from outside it is created internally. The reason for using this object is to 
be able to specify figure name suffices (and other properties). 

For instance one can do this:

reachObj=elltool.reach.ReachContinuous(....)
plObj=smartdb.disp.RelationDataPlotter('figureGroupKeySuffFunc',@(x)[x,'_mySuffi
x']);
reachObj.plotByEa(plObj);

which would lead to all figures having "_mySuffix" in their names.

You need to write tests for plotByEa/Ia, plotEa/Ia methods of 
ReachContinuous/ReachDiscrete and all ploting methods of ellipsoid class .

See the tests in smartdb.disp.test.mlunit package to learn how 
RelationDataPlotter works. 

The tests for plotting methods of ReachContinous/Discrete should be added to 
elltool.reach.test.mlunit.ReachPlotTestCase,

The tests for plotting methods of ellipsoid class should be in added in the 
corresponding test cases in elltool.core.test.mlunit package

Original issue reported on code.google.com by heartofm...@gmail.com on 8 Nov 2013 at 2:09

GoogleCodeExporter commented 8 years ago

Original comment by SeregaDrozh on 22 Nov 2013 at 7:08

GoogleCodeExporter commented 8 years ago 
Let me explain the idea - you should not create new objects in your tests - 
they are already created and put into reachObj field of the test (which you can 
access as self.reachObj). You tests should not know anything about which class 
is tested - reachDiscrete or ReachContinous. PLease have a look at other tests 
in this test case - they all do not construct any objects and they do not try 
to figure out whether it is discrete or continous class. You should not do that 
as well.

Also, please do not forget about ellipsoid class.

Original comment by heartofm...@gmail.com on 25 Nov 2013 at 2:25

GoogleCodeExporter commented 8 years ago

Original comment by SeregaDrozh on 29 Nov 2013 at 10:47

GoogleCodeExporter commented 8 years ago

Original comment by heartofm...@gmail.com on 6 Dec 2013 at 3:41

GoogleCodeExporter commented 8 years ago

Original comment by SeregaDrozh on 14 Dec 2013 at 7:13

GoogleCodeExporter commented 8 years ago

Original comment by heartofm...@gmail.com on 17 Dec 2013 at 12:49

GoogleCodeExporter commented 8 years ago

Original comment by SeregaDrozh on 23 Dec 2013 at 10:20

GoogleCodeExporter commented 8 years ago 
Looks fine but please do merge and then compare your branch with trunk using 
"Compare URL" command from repo browser (see 
http://tortoisesvn.net/docs/release/TortoiseSVN_en/tsvn-dug-diff.html). After 
merge there should be no differences apart from test modifications.

Original comment by heartofm...@gmail.com on 23 Dec 2013 at 11:33

GoogleCodeExporter commented 8 years ago

Original comment by SeregaDrozh on 24 Dec 2013 at 10:52

GoogleCodeExporter commented 8 years ago

Original comment by heartofm...@gmail.com on 25 Dec 2013 at 12:03

GoogleCodeExporter commented 8 years ago

Original comment by SeregaDrozh on 27 Dec 2013 at 6:31

GoogleCodeExporter commented 8 years ago

Original comment by heartofm...@gmail.com on 30 Dec 2013 at 3:36