Closed GoogleCodeExporter closed 8 years ago
Just a reminder that there are still some things to be done with regard to the
quality of the source code. All is describe in my reviews of your commits:
http://code.google.com/p/ellipsoids/source/detail?r=115
http://code.google.com/p/ellipsoids/source/detail?r=119
If you are lost in many different notifications - just go to
http://code.google.com/p/ellipsoids/source/list and just look at your commits,
all comments are there.
Original comment by heartofm...@gmail.com
on 25 Oct 2012 at 5:54
I've looked through ellipsoidal toolbox code and found 14 functions, which use
yalmip. I think it could be a week task(rewriting code + tests).
Original comment by vkaushanskiy
on 26 Oct 2012 at 5:07
Ok, makes sense. Just let me know when you are done with cleaning the code for
issue 13 so that I can have the final (I hope so) look and then we do
reintegrate. We really need to finish 13 this week (including all the potential
iterations). Once 13 is done I'll create a new ticket for migration to cvx.
Original comment by heartofm...@gmail.com
on 26 Oct 2012 at 5:23
Original comment by vkaushanskiy
on 27 Oct 2012 at 1:24
Original comment by vkaushanskiy
on 27 Oct 2012 at 1:25
I've discovered a few problems, please see my comments to your commit.
Original comment by heartofm...@gmail.com
on 27 Oct 2012 at 3:24
I've disabled 2 main tests from your test pack as they failed on my PC. Please
update.
YOU ARE CLEARED TO REINTEGRATE. Just be very careful, you have only one try. If
reintegrate fails you would have to delete your branch and create a new one.
Here is the procedure, please follow it to the letter:
1) Update you branch.
2) Merge trunk into your branch.
3) Commit the result of the merge.
4) Checkout latest trunk into a separate folder (or update an existing working
copy of the trunk).
5) Reintegrate to trunk FROM your branch.
6) Commit to trunk, before committing - verify once more that the tests pass,
ALL the tests, not just yours. If something wrong - do not commit.
7) Delete your branch.
Original comment by heartofm...@gmail.com
on 28 Oct 2012 at 4:09
One more thing - the tast is considered FIXED only when the automatic tests in
the trunk after you commit pass. The test currently run every 6 hours and the
results are sent to the members of the open group
https://groups.google.com/forum/?fromgroups#!forum/ellipsoids-tests-notification
. I suggest that you subscribe and make sure that the tests pass after your
reintegration. If not - you would have to create a branch for issue 13 once
more, fix the bug and reintegrate it into the trunk once more.
Original comment by heartofm...@gmail.com
on 28 Oct 2012 at 4:11
Original comment by vkaushanskiy
on 28 Oct 2012 at 6:41
Original comment by heartofm...@gmail.com
on 29 Oct 2012 at 7:34
Original issue reported on code.google.com by
heartofm...@gmail.com
on 11 Oct 2012 at 7:14