Closed GoogleCodeExporter closed 8 years ago
One the implementation and the tests are done, one needs to make sure that the
scripts that use refine from doc\mcodesnippets doesn't fail.
Original comment by heartofm...@gmail.com
on 8 Apr 2013 at 3:48
Original comment by heartofm...@gmail.com
on 14 Apr 2013 at 8:02
Original comment by vetba...@gmail.com
on 15 Apr 2013 at 7:03
Original comment by vetba...@gmail.com
on 18 Apr 2013 at 4:29
I have a question:
what exactly should I do with incorrect snippets, just fix them?
Original comment by vetba...@gmail.com
on 19 Apr 2013 at 5:04
Well, I would expect the snippets to work correctly once you have "refine"
method implemented. But if you find some problems in the snippets - have them
fixed.
Also, you still need to write tests to make sure that
1) refine works both for direct and inverse time
2) works after evolve
3) works after calling project method (i.e. once reach object is a projection
refine still should work)
Original comment by heartofm...@gmail.com
on 20 Apr 2013 at 9:31
May I put these tests in ContinuousReachRefineTestCase.m, or should I put them
somewhere else?
Original comment by vetba...@gmail.com
on 20 Apr 2013 at 12:25
Yes, you may.
Original comment by heartofm...@gmail.com
on 20 Apr 2013 at 12:39
I checked snippets, There are three of them that use refine. One is for
discrete case, the other one looks like this:
Y = ellipsoid([8; 2], [4 1; 1 2]); % target set in the form of ellipsoid
Tb = [10 5]; % backward time interval
brs = elltool.reach.ReachContinuous(sys, Y, L, Tb); % backward reach set
brs = refine(brs, L1); % refine the approximation
brs2 = evolve(brs, 0); % further evolution in backward time from 5 to 0
So, It looks correct but the question is how should I check it if directions L1
are not specified?
Original comment by vetba...@gmail.com
on 20 Apr 2013 at 11:44
All snippets are numbered and some of them are intended for running in
sequence, just look in the snippets that precede the current one. For more
information please contact Irina.
Original comment by heartofm...@gmail.com
on 21 Apr 2013 at 12:15
Do the snippets work now?
Original comment by heartofm...@gmail.com
on 21 Apr 2013 at 6:26
Now all snippets with refine work correctly.
Original comment by vetba...@gmail.com
on 25 Apr 2013 at 8:45
I don't understand why you flip indVec ( see my comment to one of your commits).
Original comment by heartofm...@gmail.com
on 26 Apr 2013 at 10:43
Reintegration produced a lot of errors and test failures, please investigate
Original comment by heartofm...@gmail.com
on 27 Apr 2013 at 1:39
I'm sorry, yesterday I have confused you and miself. This reverting should not
be done in here, since even though the cicle is backward it calculates result
in the right order. So, now all the tests work correctly.
Original comment by vetba...@gmail.com
on 27 Apr 2013 at 3:35
Original comment by heartofm...@gmail.com
on 27 Apr 2013 at 8:25
Original issue reported on code.google.com by
heartofm...@gmail.com
on 8 Apr 2013 at 3:26