Something I asked about multiple times. Is it true that the T/C wildcards should be happening at the same time as the A/G wildcards? In other words, should the function:
static bool
similar_letters_bisulfite(const char a, const char b) {
return (a == b) || (a == 'T' && b == 'C') || (a == 'G' && b == 'A');
}
actually be two functions:
static bool
similar_letters_bisulfite_CT(const char a, const char b) {
return (a == b) || (a == 'T' && b == 'C');
}
static bool
similar_letters_bisulfite_GA(const char a, const char b) {
return (a == b) || (a == 'G' && b == 'A');
}
It would be good to add an explanation of how/why the issue was closed. That way someone reading it a year from now will understand, and be certain that no error was made by accidentally closing it.
Something I asked about multiple times. Is it true that the T/C wildcards should be happening at the same time as the A/G wildcards? In other words, should the function:
static bool similar_letters_bisulfite(const char a, const char b) { return (a == b) || (a == 'T' && b == 'C') || (a == 'G' && b == 'A'); }
actually be two functions:
static bool similar_letters_bisulfite_CT(const char a, const char b) { return (a == b) || (a == 'T' && b == 'C'); }
static bool similar_letters_bisulfite_GA(const char a, const char b) { return (a == b) || (a == 'G' && b == 'A'); }