search

xkaze09 / dpsm-website

The official website of UPV's Division of Physical Sciences and Mathematics (DPSM) that provides comprehensive information about the department and its college courses. Now live!
https://www.upvdpsm.com/
6 stars 1 forks source link

Prospectus table per course does not load properly on mobile #98

Closed xkaze09 closed 6 months ago

xkaze09 commented 7 months ago

See image below: image

xkaze09 commented 7 months ago

New images below. From MacBook & another iPhone device:

image image

ezerssss commented 7 months ago
  • The prospectus table does not load < 400px, specifically iPhone-sized screen sizes.
  • F12 dev tools may show it just fine

See image below: image

Can you open the console to check if there may be errors? seems that the JSON file is not loaded thus not rendering the rows. Might be a fetching issue that iOS is preventing.

xkaze09 commented 6 months ago
  • The prospectus table does not load < 400px, specifically iPhone-sized screen sizes.
  • F12 dev tools may show it just fine

See image below: image

Can you open the console to check if there may be errors? seems that the JSON file is not loaded thus not rendering the rows. Might be a fetching issue that iOS is preventing.

Turns out that /data.json was not being loaded properly.

Fixed it by fetching it asynchronously and only then will generateProspectusTable be called.

For more information, see latest commit at #99.

Issue will now be marked as resolved, should there be no additional issues.