search

xkbcommon / libxkbcommon

keymap handling library for toolkits and window systems
https://xkbcommon.org
Other
278 stars 124 forks source link

XKB overlays are missing. #124

Open AlbertoGP opened 4 years ago

AlbertoGP commented 4 years ago

Hi, I know that overlays are purposely left out as mentioned in (libxkbcommon/doc/compat.md, and this comment in #18.

Well, I do use them extensively, which is a problem as I’m trying to switch to Wayland. I use only one of the two overlays supported by XKB, but going from zero to one makes a big difference. It allows me to have features normally only available on programmable keyboards with any keyboard while using Linux.

I’m ready to work on a patch, but I’ll need at least some hints about where in the codebase to put the code.

I found HandleSetLockControls(...) in xkbcomp/action.c, and translate_controls_mask(...) in x11/keymap.c which says /* Some controls are not supported and don't appear here. */.

I suppose I would have to define a constant CONTROL_OVERLAY in src/keymap.h and add it to translate_controls_maks(...). Is that correct?

Where would the overlay key remapping be handled?

bluetech commented 4 years ago

Overlays are cool (would be interesting to see your keymap using them!).

They were quite a complex feature, and did not see enough use to pull their weight, so we removed them in xkbcommon. If you provide a patch, we'll certainly consider it, though we can't guarantee we'll accept it.

I’ll need at least some hints about where in the codebase to put the code.

xkbcommon is directly derived from xkbcomp and the XKB code in the xserver. So you can basically see how overlays are implemented there. I have never investigated them much myself.

One issue you'll eventually hit, as you found out, is that overlays use "controls" -- these are separate parts of the XKB state, like depressed/latched/locked modifeirs/layouts. Activating an overlay toggles a bit in the controls state. The problem is that in xkbcommon this state component went entirely unused, so was removed from the API (e.g. the xkb_state_component enum and state serialization functions). I suppose you can ignore this problem to start out with.

wismill commented 1 day ago

I have a draft PR, see #514. I do not see much issue with controls, but rather find it difficult to not mess with keycode redirections, or rather: not make it complicated to use for compositors. It requires extreme rigor to redirect keycode at this level.

However, permanent overlays could be completely internal (just copy the target key) and thus make it easy to permute keys in XKB.