search

xkbcommon / libxkbcommon

keymap handling library for toolkits and window systems
https://xkbcommon.org
Other
286 stars 125 forks source link

meson.build script broke detection of --version-script support in GNU ld, as NetBSD uses #481

Closed wismill closed 4 months ago

wismill commented 6 months ago

Originally posted by @glechapelain in https://github.com/xkbcommon/libxkbcommon/issues/459#issuecomment-2134184602:

I'll verify here but this seems to be causing grieves to pkgsrc using GNU: https://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=58272

Relevant PR: #459

wismill commented 6 months ago

@glechapelain from their changelog --undefined-version seems supported in recent GNU ld versions (I cannot find which precisely):

2022-10-14  Fangrui Song  <i@maskray.me>

    ld: Add --undefined-version
    This cancels a previous --no-undefined-version.
    gold has had --undefined-version for a long time.

From this page I would say since binutils-2.40 (2023-01-14).

@whot @bapt that’s as much debugging I can do 😄

glechapelain commented 5 months ago

Then it is what it is and the bug is not relevant ? (And on Pkgsrc a toolchain of a certain degree is required to compile the sources from a certain revision? I would expect that.

We're at 2.39)

eli-schwartz commented 5 months ago

Certainly it is a bug if libxkbcommon depends on linker options that only work with specific bleeding-edge versions of binutils.

I am surprised that the broken PR was ever merged, at least in the state it was in. This is an lld-specific issue, so it should have been gated on cc.get_linker_id() == 'lld'.