Current test suite is directly querying Blizzard's API

xklusive / laravel-battlenet-api

Laravel 5 client for Battle.net API

MIT License

8 stars 3 forks source link

Current test suite is directly querying Blizzard's API #32

Closed atraides closed 5 years ago

atraides commented 6 years ago

Currently for the test case we are actually query a 3rd party website which may cause problems with the testing. More detailed explanation here: https://us.battle.net/forums/en/bnet/topic/20757486127

We should change this so the test suite only test the library functionality and not impacted by the connection to Blizzard.

atraides commented 5 years ago

Recreated the entire test suite to use mock responses, speeding up the process a lot. Also made it more reliable. We don't have to worry if the Blizzard API is accessible at the time of testing or not.