crash in network forwarding #2

xkmo / growl

Automatically exported from code.google.com/p/growl

0 stars 0 forks source link

crash in network forwarding #2 #335

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

this crash is happening further into the sending process, when it tries to 
connect to the given address. This is related to #334 and likely one will fix 
the other. Investigate for inclusion in 1.3.1.

Original issue reported on code.google.com by rarich...@gmail.com on 21 Oct 2011 at 4:54

GoogleCodeExporter commented 9 years ago

Original comment by rarich...@gmail.com on 21 Oct 2011 at 4:54

Attachments:

Growl_2011-10-21-081059_rayganmbp.crash

GoogleCodeExporter commented 9 years ago

Both this, and 334, I suspect are related to generating the address data for 
where to send to.  Rudy has told me that the user is using Bonjour found 
system, which shouldn't be a problem, and any fix I would make would be 
guesswork really at this point, which is not a good thing to do.  
While looking at the address data generating code, I noticed one case that 
wasn't entirely properly covered, but it seems like it wouldn't matter, and it 
would still return nil, and not try to send anything to that host.  I would 
like to see your info.plist, or at least the GrowlForwardDestinations key and 
any children (~/Library/Preferences/com.Growl.GrowlHelperApp.plist) to know if 
that might even remotely affect this.

Original comment by dan...@growl.info on 22 Oct 2011 at 2:49

GoogleCodeExporter commented 9 years ago

Original comment by ch...@growl.info on 31 Oct 2011 at 2:56

Added labels: Milestone-1.4

GoogleCodeExporter commented 9 years ago

Original comment by ch...@growl.info on 19 Jan 2012 at 10:11

Added labels: Milestone-2.0

GoogleCodeExporter commented 9 years ago

Thanks to Thijs Alkemade, we might have a fix for this and 
http://code.google.com/p/growl/issues/detail?id=334  in 1.4.

Apparently the data for address was being returned without an owner, and slim 
chance it wasn't getting retained properly before it died.  We now copy and 
autorelease the data as we return it instead of just returning it.

Original comment by dan...@growl.info on 1 Feb 2012 at 8:03

Changed state: Started

GoogleCodeExporter commented 9 years ago

Original comment by ch...@growl.info on 23 Feb 2012 at 9:07

Added labels: Milestone-1.4
Removed labels: Milestone-2.0

GoogleCodeExporter commented 9 years ago

Marking as fixed based on Daniel's comment.

Original comment by ch...@growl.info on 23 Feb 2012 at 9:46

Changed state: FixedInSource

GoogleCodeExporter commented 9 years ago

Original comment by ch...@growl.info on 11 Jan 2013 at 6:36

Changed state: Fixed