search

xkos / wagic

Automatically exported from code.google.com/p/wagic
0 stars 0 forks source link

Manabarbs doesn't trigger for dual lands #562

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Have manabarbs in play, tap a dual land for mana.
Manabarbs should do 1 damage to you, but that doesn't happen.

Attached test for verification, I will also add it to the SVN

Original issue reported on code.google.com by wagic.the.homebrew@gmail.com on 15 Dec 2010 at 1:25

Attachments:

GoogleCodeExporter commented 8 years ago 
added manabarbs_dual_lands_i562.txt to the svn Res/test/bugs folder

Original comment by wagic.the.homebrew@gmail.com on 15 Dec 2010 at 1:36

GoogleCodeExporter commented 8 years ago 
the "why" kinda bothers me ALOT...

    if (tap)
    {
        GameObserver *g = GameObserver::GetInstance();
        WEvent * e = NEW WEventCardTappedForMana(source, 0, 1);
        g->receiveEvent(e);
        source->tap();
    }

this is in manaproducer....yet these specail lands NEVER trigger a breakpoint 
in this...its "tapping" is being handled else where.

Original comment by omegabla...@gmail.com on 15 Dec 2010 at 6:24

GoogleCodeExporter commented 8 years ago 
activated ability was handling the reactto click calls for these types of mana 
producers, because of the menu....already have a fix for this, but i will say 
im not happy that classes that have their OWN functions are being over ridden 
by the base class...i thought it was supposed to be the other way around.

soon as test suite is done ill commit the change.

Original comment by omegabla...@gmail.com on 15 Dec 2010 at 6:48

GoogleCodeExporter commented 8 years ago 
fixed, enjoy, BTW
becomes test 2....this should have been uber failing on you as it was coded by 
what looks like mikes kids...and not him...i went ahead and fixed that test 
too, and also fixed the mana cost of plummet which was {g} instead of {g}{1}....

Original comment by omegabla...@gmail.com on 15 Dec 2010 at 7:31

GoogleCodeExporter commented 8 years ago

Original comment by omegabla...@gmail.com on 15 Dec 2010 at 7:31