xkos / wagic

Automatically exported from code.google.com/p/wagic
0 stars 0 forks source link

Integrate patches from ittobaal #566

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Attached file contains a series of bug fixes sent on the forum by user ittobaal.
Let's
1) verify what the patches do
2) Integrate them

from ittobaal :
JGE/src/JGBKFont.cpp "bad" de-allocation
JGE/src/pc/JGfx.cpp memory leaks, it will most likely not even be felt on the 
PC version
projects/mtg/src/WFont.cpp "bad" de-allocation

In \JGE\src\unzip filedescriptor leaks
In \JGE\src filedescriptor and memory leaks
Same path, JDistortionMesh_cpp.patch, mem leak(???) due to incorect delete 

Original issue reported on code.google.com by wagic.the.homebrew@gmail.com on 19 Dec 2010 at 10:44

GoogleCodeExporter commented 8 years ago
attaching the patch

Original comment by wagic.the.homebrew@gmail.com on 19 Dec 2010 at 10:44

Attachments:

GoogleCodeExporter commented 8 years ago
Making high priority so that we review this before the source changes too much

Original comment by wagic.the.homebrew@gmail.com on 19 Dec 2010 at 10:45

GoogleCodeExporter commented 8 years ago

Original comment by wrenc...@gmail.com on 27 Dec 2010 at 8:26

GoogleCodeExporter commented 8 years ago
Is there a reason why the patches didn't make it in?

Original comment by Ittobaal@gmail.com on 30 Dec 2010 at 9:04

GoogleCodeExporter commented 8 years ago
They made it in, but were a bit reworked maybe?
http://code.google.com/p/wagic/source/detail?r=2870

Original comment by wagic.the.homebrew@gmail.com on 30 Dec 2010 at 9:06

GoogleCodeExporter commented 8 years ago
Yeah i just realised most of them made it in, foot in mouth situation, however 
the fix for the array delete:
src/WFont.cpp, has not made it in.

Original comment by Ittobaal@gmail.com on 30 Dec 2010 at 9:18

GoogleCodeExporter commented 8 years ago
My bad, I still had this file open locally.  Checked in now.

Original comment by wrenc...@gmail.com on 11 Jan 2011 at 9:13