search

xkszltl / Roaster

Build open-source tools from scratch with Roaster!
Apache License 2.0
16 stars 9 forks source link

Add utf8proc lib #3

Closed walleva closed 4 years ago

walleva commented 4 years ago
  1. Add utf8proc to linux pkgs
  2. Add utf8proc to win nuget
xkszltl commented 4 years ago

@walleva Thanks for contribution!

Here are a few things to note:

  1. Make sure you build and pack it once on Windows.
  2. Drop CMAKE_INSTALL_PREFIX on Windows to check if it's installed to the same location as specified. We want to be explicit there but also want it to align with upstream default behavior.
  3. Use a pre-built roaster docker to try out on Linux.
  4. Make sure unit tests are run to validate our build.
  5. Public CI is not working yet due to disk size limit of agents.
  6. Once comments are addressed I'll import it for internal tests.
walleva commented 4 years ago

@xkszltl I've enabled testing of utf8proc and cleaned up scripts according to your comments. I tested on oneocr linux dev container and win10. Both worked. The three failed checks were caused by disk size limit, as you mentioned in the 5th point of notes. Could you pls help review this pr again? Thank you!

xkszltl commented 4 years ago

Imported for internal test.